Daniel Boles [Wed, 31 May 2017 18:08:28 +0000 (19:08 +0100)]
Adwaita: Add missing rule for fullscreen headerbar
Another selector forces round corners for headerbars in a stack, and it
has higher priority than the selector covering the non-stack case from
commit
712a8adbd9a11fcebce0269562e9a028a17fa862. Totem’s MainToolbar
happens to be in a stack, and we should maintain symmetry here anyway.
So, as window classes .maximized and .tiled are excluded from this other
selector, the newly handled .fullscreen case must be excluded here also.
https://bugzilla.gnome.org/show_bug.cgi?id=770513
Daniel Boles [Wed, 31 May 2017 17:45:59 +0000 (18:45 +0100)]
HighContrast: Regenerate CSS files with sassc
Daniel Boles [Wed, 31 May 2017 17:45:24 +0000 (18:45 +0100)]
HighContrast: Update parse-sass.sh; remove Gemfile
Make parse-sass.sh use sassc instead of the old Ruby method.
Daniel Boles [Wed, 31 May 2017 17:45:04 +0000 (18:45 +0100)]
Adwaita: Remove unused Gemfile
Daniel Boles [Wed, 31 May 2017 07:16:46 +0000 (08:16 +0100)]
themes: Square corners on fullscreen win headerbar
Totem uses a fullscreen window with a headerbar at the top, and without
this change, that headerbar has rounded corners, which look different
from a maximised window and let video content show through beneath.
https://bugzilla.gnome.org/show_bug.cgi?id=770513
Aurimas Černius [Tue, 30 May 2017 19:32:23 +0000 (22:32 +0300)]
Updated Lithuanian translation
Debarshi Ray [Wed, 24 May 2017 14:42:01 +0000 (16:42 +0200)]
wayland: Don't warn if the display is lost, skip exit handlers
There is no need to have every application log a warning when the
Wayland display server goes away, and we are using _exit instead of
exit elsewhere.
This is also what the X11 backend does (see gdk_x_io_error).
https://bugzilla.gnome.org/show_bug.cgi?id=745289
Марко Костић [Sat, 27 May 2017 22:41:26 +0000 (22:41 +0000)]
Update Serbian translation
Debarshi Ray [Wed, 24 May 2017 14:08:07 +0000 (16:08 +0200)]
wayland: Don't abort when preparing the source if connection is lost
Aborting the application makes it look like an application bug, when
it is the expected thing to do when the Wayland display server goes
way. eg., when the user logs out. The log level is also demoted to
avoid a storm of warnings in the log from all applications whenever
this happens.
This is also what the X11 backend does (see gdk_x_io_error).
https://bugzilla.gnome.org/show_bug.cgi?id=783047
Emmanuele Bassi [Tue, 23 May 2017 04:12:41 +0000 (05:12 +0100)]
textview: Make GTK_TEXT_WINDOW_PRIVATE public
The GTK_TEXT_WINDOW_PRIVATE enumeration value is really *not* private.
Internally, it's used as a simple "invalid value" marker, and
application and library developers are supposed to use it as such in
their own code.
Let's just document it, and since the GtkTextView documentation and
internals go a long way to state the fact that it should not be used as
an argument value, let's add some pre-condition checks as well.
This commit fixes GtkSourceView's use of GTK_TEXT_WINDOW_PRIVATE as
default value for a GObject property that was broken by the change in
glib-mkenums to honor the `/*< public >*/` and `/*< private >*/`
trigraphs.
Jonas Ådahl [Mon, 8 May 2017 12:51:43 +0000 (20:51 +0800)]
tests: Add testforeign
Add a test for exporting a handle. There are no GTK+ API for this, but
only per backend GDK API, and so far only Wayland is supported. There
is a private GdkWindow API but it's not exposed externally.
https://bugzilla.gnome.org/show_bug.cgi?id=782325
Jonas Ådahl [Mon, 8 May 2017 10:35:50 +0000 (18:35 +0800)]
GdkWaylandWindow: Allow calling export() multiple time
Allow getting the same export handle multiple times by calling
gdk_wayland_window_export_handle() multiple times. For each time
export() is called, a unexport() must be called to unexport.
When the window is already exported, the exported callback is called
via a idle handler. If there are multiple export() calls, they are
invoked in order either when the handle is received by the display
server, or when the idle callback is invoked.
Calling unexport() will not affect future invokations of the exported
callback, unless all export() calls have their unexport() call count
matched.
https://bugzilla.gnome.org/show_bug.cgi?id=782325
Olof-Joachim Frahm [Sun, 26 Feb 2017 15:02:49 +0000 (16:02 +0100)]
Move style change for popover creation.
Creating with `gtk_popover_new_from_model` should be exactly the same as
if via `gtk_popover_new` plus `gtk_popover_bind_model`.
Also remove the style if the model is unbound at any point.
Timm Bäder [Tue, 2 May 2017 18:54:57 +0000 (20:54 +0200)]
widget: Remove useless assignment
We don't use adjusted_allocation after this line.
Timm Bäder [Sat, 24 Sep 2016 07:36:32 +0000 (09:36 +0200)]
examples/drawing: Don't call gtk_main_quit
This is a GtkApplication so it will do the right thing when closing the
window.
Timm Bäder [Sun, 21 Aug 2016 13:43:29 +0000 (15:43 +0200)]
fallback-c89: Include config.h
It holds all the HAVE_<func> definitions.
Timm Bäder [Sun, 30 Apr 2017 18:21:39 +0000 (20:21 +0200)]
widget: remove double assignment
We never read the value we assign here.
Timm Bäder [Sun, 30 Apr 2017 18:20:58 +0000 (20:20 +0200)]
placesview: Remove duplicate GtkMountOperation assignment
we assign a new mount operation a few lines later again.
Timm Bäder [Sun, 30 Apr 2017 18:19:56 +0000 (20:19 +0200)]
levelbar: Don't allocate 0 blocks
Could result in a division by zero later on and doesn't make a lot of
sense anyway.
Timm Bäder [Fri, 28 Apr 2017 09:25:21 +0000 (11:25 +0200)]
grid: Remove unnecessary NULL checks
The minimum and natural pointers passed to measure are never NULL and
that's the only place where we call gtk_grid_get_size_for_size.
Timm Bäder [Thu, 27 Apr 2017 15:54:49 +0000 (17:54 +0200)]
GtkGestureMultiPress: Remove superfluous NULL check
The rect parameter in gtk_gesture_multi_press_set_area is annotated as
nullable and the code handles the rect==NULL case, but the
g_return_if_fail kept that case from ever happening.
Timm Bäder [Thu, 27 Apr 2017 15:52:46 +0000 (17:52 +0200)]
label: Remove dead ternary operator
Timm Bäder [Wed, 26 Apr 2017 11:43:30 +0000 (13:43 +0200)]
filechooserwidget: Remove always-false error case
_gtk_search_engine_new never returns NULL, it always returns a valid
GObject with at least the simple search engine initialized.
Timm Bäder [Wed, 26 Apr 2017 09:37:58 +0000 (11:37 +0200)]
sidebarrow: Remove useless size group
Nice try, but size groups don't work with invisible widgets anyway.
Invisible widgets request 0×0.
Timm Bäder [Tue, 25 Apr 2017 13:43:10 +0000 (15:43 +0200)]
label: Remove useless if statements
We never pass nullable pointers into get_size_for_allocation.
Olivier Fourdan [Wed, 3 May 2017 12:29:18 +0000 (14:29 +0200)]
gtkwindow: Hide CSD title bar when undecorated
When switching from decorated to undecorated, the title bar should be
hidden as well.
https://bugzilla.gnome.org/show_bug.cgi?id=782117
Robert Ancell [Sat, 20 May 2017 01:07:05 +0000 (13:07 +1200)]
docs: Fix copy-paste error in gtk_file_chooser_get_extra_widget() doc comment
Lapo Calamandrei [Wed, 17 May 2017 16:09:59 +0000 (18:09 +0200)]
Adwaita: Avoid accindental border on last treeview header
The :last-child selector supposed to reset the border was
overridden by the :hover selector. This is fixed by moving the
:last-child selector after the overriding one.
Thanks to Sebastian Keller for spotting.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=779078.
Lapo Calamandrei [Wed, 17 May 2017 16:06:39 +0000 (18:06 +0200)]
Adwaita: regenerate the css with sassc
Lapo Calamandrei [Wed, 17 May 2017 16:05:13 +0000 (18:05 +0200)]
Adwaita: modify parse-sass.sh script to use sassc
Robert Ancell [Mon, 15 May 2017 05:03:36 +0000 (17:03 +1200)]
EntryBuffer: Don't generate changed events when input is truncated
Daniel Boles [Sat, 13 May 2017 20:55:28 +0000 (21:55 +0100)]
widget-factory: Use :relief=none, not class .flat
The rest of the ui file follows that convention.
Matthias Clasen [Thu, 11 May 2017 19:09:33 +0000 (15:09 -0400)]
3.22.15
Timm Bäder [Thu, 11 May 2017 13:33:13 +0000 (15:33 +0200)]
listbox: Manually unparent placeholder in dispose
We can't make the placeholder a non-internal child as that breaks
applications that previously relied on foreach() to only return
GtkListBoxRow instances. Instead, unparent the placeholder manually in
dispose.
https://bugzilla.gnome.org/show_bug.cgi?id=782494
Matthias Clasen [Thu, 11 May 2017 19:01:05 +0000 (15:01 -0400)]
Revert "listbox: Properly remove placeholders"
This reverts commit
b7fdc5b447b44b5b7638a3ac41cac58136bc5ca2.
This was found to break the expectations of existing listbox
users.
Lapo Calamandrei [Thu, 11 May 2017 13:19:19 +0000 (15:19 +0200)]
Adwaita: regenerate the css
Lapo Calamandrei [Thu, 11 May 2017 12:36:57 +0000 (14:36 +0200)]
Adwaita: restyle entry-tag
Fix the sizing and spacing, blue tags for the bright variant,
similar to what gnome-documents was shipping, and inverted gray
tags for the dark variant, not vanishing on hover.
Matthias Clasen [Wed, 10 May 2017 18:57:00 +0000 (14:57 -0400)]
3.22.14
Carlos Garnacho [Wed, 10 May 2017 18:20:50 +0000 (20:20 +0200)]
gtkclipboard: Fix typo
The standard atom is UTF8_STRING.
Emmanuele Bassi [Wed, 10 May 2017 13:31:09 +0000 (14:31 +0100)]
build: Fix the check on sassc's presence
If sassc is not available we do not want to include the rules to
regenerate the CSS out of the SCSS files.
Chun-wei Fan [Wed, 10 May 2017 01:25:43 +0000 (18:25 -0700)]
build/win32/replace.py: Fix replacing items in files with UTF-8 content
Some files that this script will process might have UTF-8 items in
there, which can cause problems on Python 3.x as it is more strict and
careful on unicode issues.
Fix this by:
-Doing what we did before on Python 2.x
-Opening the file with encoding='utf-8' on Python 3.x
Matthias Clasen [Tue, 9 May 2017 16:58:11 +0000 (12:58 -0400)]
3.22.13
Matthias Clasen [Tue, 9 May 2017 18:01:22 +0000 (14:01 -0400)]
Fix the build
It seems that new gtk-doc doesn't like this variable,
so drop it.
Jonas Ådahl [Tue, 9 May 2017 15:07:02 +0000 (23:07 +0800)]
GtkWindow: Don't double free export user data
The user data passed when exporting a Wayland window was supposed to be
freed using the destroy_func, as is commonly done. This was previously
broken, as the user data was just NULL:ed when exported, and only
actually destroyed when unexporting before having exported.
While
e016d9a5dba6f6f99aee94d0b72c00bee299b96a fixed this, it introduced
a regression, as GtkWindow was nice enough to free the memory anyway
after having received the exported handle, causing it now to double
free.
https://bugzilla.gnome.org/show_bug.cgi?id=782109
Emmanuele Bassi [Tue, 9 May 2017 13:30:40 +0000 (14:30 +0100)]
build: Disable deprecation warnings in broadway
Avoid compiler warnings while building code that uses deprecated API.
Emmanuele Bassi [Wed, 3 May 2017 14:46:35 +0000 (15:46 +0100)]
Specify more options to sassc
We should use the compact style, to minimize the whitespace; and we
should omit the source map URL comment as well.
Emmanuele Bassi [Wed, 3 May 2017 14:45:15 +0000 (15:45 +0100)]
build: De-duplicate options to sassc
If we want to change the list of options we use with sassc, not having
to copy-paste them in multiple rules would be a good start.
Emmanuele Bassi [Sun, 30 Apr 2017 15:06:29 +0000 (16:06 +0100)]
build: Enable subdir-objects
Like we did in the master branch.
Using subdir-objects removes the forward compatibility warnings coming
from autotools.
Emmanuele Bassi [Sun, 30 Apr 2017 15:05:49 +0000 (16:05 +0100)]
build: Remove unused rules
The foreign drawing example was moved to the GTK demos.
Emmanuele Bassi [Fri, 28 Apr 2017 20:50:41 +0000 (21:50 +0100)]
build: Don't include the marshallers header file
We used to inject the inclusion of the generated header file into the
generated body of the marshallers source code in order to avoid compiler
warnings about missing prototypes. The glib-genmarshal utility has been
fixed in GLib to include the prototype in the generated source, so now
we're going to trip -Werror=redundant-decls.
Lapo Calamandrei [Tue, 9 May 2017 11:32:56 +0000 (13:32 +0200)]
Adwaita: regenerate css
Lapo Calamandrei [Tue, 9 May 2017 11:31:31 +0000 (13:31 +0200)]
Adwaita: add a comment
Add a comment pointing to the related bug for the dropdown menu
margin.
Lapo Calamandrei [Tue, 9 May 2017 11:27:51 +0000 (13:27 +0200)]
Revert "Adwaita: remove unneeded margin on dropdown menu"
This reverts commit
bb1679b247a8805a9c87a41dcd10a2ae8b2d65d3.
The margin was actually related to:
https://bugzilla.gnome.org/show_bug.cgi?id=591258
Lapo Calamandrei [Tue, 9 May 2017 11:26:42 +0000 (13:26 +0200)]
Revert "Adwaita: regenerate the css"
This reverts commit
f2f09b957441e26b0fe9ce51626b086f2b12e2c5.
Olof-Joachim Frahm [Sun, 5 Feb 2017 18:08:56 +0000 (19:08 +0100)]
Make sure to remove tooltip timeout.
Otherwise in GC-ed environments the `g_source_remove` call during
disposal might be called on an already removed source, which results in
unnecessary console output.
https://bugzilla.gnome.org/show_bug.cgi?id=778301
Lapo Calamandrei [Tue, 9 May 2017 10:50:49 +0000 (12:50 +0200)]
Adwaita: regenerate the css
Lapo Calamandrei [Tue, 9 May 2017 10:45:22 +0000 (12:45 +0200)]
Adwaita: remove unneeded margin on dropdown menu
That margin was probably a left over to workaround some placement
issue on dropdowns which doesn't exist anymore.
Gianvito Cavasoli [Tue, 9 May 2017 08:48:31 +0000 (08:48 +0000)]
Update Italian translation
Jonas Ådahl [Mon, 8 May 2017 04:09:00 +0000 (12:09 +0800)]
GdkWaylandWindow: Unexport when finalizing
The application might not have exported, and it'll be too late for it
at this point anyway, so lets be helpful and not leak it.
https://bugzilla.gnome.org/show_bug.cgi?id=782109
Timm Bäder [Thu, 30 Mar 2017 07:02:00 +0000 (07:02 +0000)]
box: Initialize size arrays to 0
Thats the right thing to do.
https://bugzilla.gnome.org/show_bug.cgi?id=773814
Jakub Steiner [Thu, 13 Apr 2017 17:38:53 +0000 (19:38 +0200)]
style entry-tags
https://bugzilla.gnome.org/show_bug.cgi?id=781214
Jonas Ådahl [Mon, 20 Mar 2017 13:37:10 +0000 (21:37 +0800)]
wayland: Remove self assignment
Don't assign the value of a variable to itself. It was added just for
clarity, but it makes coverity complain, so remove it.
https://bugzilla.gnome.org/show_bug.cgi?id=780301
Jonas Ådahl [Mon, 20 Mar 2017 13:36:29 +0000 (21:36 +0800)]
wayland: Use correct enum type and values
Use the gravity enum values when converting to gravity. It doesn't fix
anything, since the enum values were identical, but it makes a coverity
warning go away.
https://bugzilla.gnome.org/show_bug.cgi?id=780301
Matthias Clasen [Mon, 8 May 2017 20:35:53 +0000 (16:35 -0400)]
file filter: Be save against NULL
g_content_type_from_mime_type may return NULL, deal with that.
https://bugzilla.gnome.org/show_bug.cgi?id=782180
Matthias Clasen [Mon, 8 May 2017 20:00:49 +0000 (16:00 -0400)]
Revert "GdkWaylandWindow: Unexport when finalizing"
This reverts commit
ab4e4bd3aec6aeb3df6de16bd12d7f538de39061.
Jonas Ådahl [Mon, 8 May 2017 04:09:00 +0000 (12:09 +0800)]
GdkWaylandWindow: Unexport when finalizing
The application might not have exported, and it'll be too late for it
at this point anyway, so lets be helpful and not leak it.
https://bugzilla.gnome.org/show_bug.cgi?id=782109
Jonas Ådahl [Fri, 5 May 2017 11:07:04 +0000 (19:07 +0800)]
GdkWaylandWindow: Clear export user data when used
It was only cleared when unexported, but we could just as well clear it
when its used too.
https://bugzilla.gnome.org/show_bug.cgi?id=782109
Mohammed Sadiq [Fri, 5 May 2017 05:22:27 +0000 (10:52 +0530)]
linkbutton: Fix memory leak
strings returned by gtk_widget_get_tooltip_text() and
gtk_widget_get_tooltip_markup() has to be freed when no longer
required.
https://bugzilla.gnome.org/show_bug.cgi?id=782202
Michael Catanzaro [Sun, 30 Apr 2017 18:26:13 +0000 (13:26 -0500)]
menubutton: Remove prelight state when button is deactivated
If the button is deactivated, it should not appear to be hovered
anymore.
https://bugzilla.gnome.org/show_bug.cgi?id=781992
Balázs Úr [Fri, 5 May 2017 18:52:59 +0000 (18:52 +0000)]
Update Hungarian translation
Christoph Reiter [Wed, 26 Apr 2017 10:46:40 +0000 (12:46 +0200)]
gtkdnd: restore drag window movement for the unmanaged case
5bb12474d975ee4b790c5 removed the dnd window movement code to let
the gdk backends handle the window movement instead. While this
works for X11/wayland the win32 backend still uses the unmanaged
interface and expects the window movement to be handled on the gtk
side. This restores the functionality in case the dnd is unmanaged.
This fixes the drag window on Windows being stuck in the top left
corner instead of following the drag position.
https://bugzilla.gnome.org/show_bug.cgi?id=781737
Paolo Borelli [Sun, 30 Apr 2017 14:02:15 +0000 (16:02 +0200)]
shortcutssection: plug a tiny mem leak
Matthias Clasen [Wed, 3 May 2017 21:08:29 +0000 (17:08 -0400)]
clipboard: Try the mimetype first
Try text/plain;charset=utf-8 first, before falling back to
X11-isms like UTF8_TEXT. This makes things work on Wayland
compositors that don't carry a heavy X11 legacy around.
https://bugzilla.gnome.org/show_bug.cgi?id=781814
Lapo Calamandrei [Wed, 3 May 2017 15:47:14 +0000 (17:47 +0200)]
Adwaita: regenerate css
Lapo Calamandrei [Wed, 3 May 2017 15:39:21 +0000 (17:39 +0200)]
Adwaita: add more space between check/radio and label in popovers
See https://bugzilla.gnome.org/show_bug.cgi?id=779570 for details.
Daniel Boles [Tue, 2 May 2017 11:22:20 +0000 (12:22 +0100)]
Scale: Improve documentation of set_has_origin()
Properly format the property name, and avoid saying scale so many times.
Daniel Boles [Tue, 2 May 2017 11:18:26 +0000 (12:18 +0100)]
Scale: Explain how to round value when !draw-value
Scale:digits is (now, again) ineffective if Scale:draw-value is FALSE.
To get rounding in that case, the base Range:round-digits must be used.
Anders Jonsson [Mon, 1 May 2017 22:25:39 +0000 (22:25 +0000)]
Update Swedish translation
Dušan Kazik [Sun, 30 Apr 2017 08:01:40 +0000 (08:01 +0000)]
Update Slovak translation
Мирослав Николић [Sun, 30 Apr 2017 06:47:39 +0000 (08:47 +0200)]
Updated Serbian translation
Мирослав Николић [Sun, 30 Apr 2017 06:30:24 +0000 (08:30 +0200)]
Updated Serbian translation
Мирослав Николић [Sun, 30 Apr 2017 06:25:14 +0000 (08:25 +0200)]
Updated Serbian translation
Мирослав Николић [Sun, 30 Apr 2017 06:15:13 +0000 (08:15 +0200)]
Updated Serbian translation
Kukuh Syafaat [Sat, 29 Apr 2017 02:09:31 +0000 (02:09 +0000)]
Update Indonesian translation
Olivier Fourdan [Wed, 26 Apr 2017 13:35:42 +0000 (15:35 +0200)]
wayland: make key event log more explicit
With Wayland, GDK_DEBUG=events would log key events but not explicitly
state whether the event is a key press or release, or if it's
originating from a key repeat.
Add some more verbosity to make sure these informations are logged on
key delivery when GDK_DEBUG is set.
https://bugzilla.gnome.org/show_bug.cgi?id=781767
Mario Blättermann [Fri, 28 Apr 2017 09:50:43 +0000 (09:50 +0000)]
Update German translation
Florian Müllner [Sat, 22 Apr 2017 17:50:11 +0000 (19:50 +0200)]
gdk: Relicense translate_wm_button_layout_to_gtk()
It is generally a good idea to license individual files under the
same terms as the project license (in particular when the mismatch
boils down to having copied the wrong license header), so relicense
the code under the LGPL.
https://bugzilla.gnome.org/show_bug.cgi?id=781422
Rafael Fontenelle [Thu, 27 Apr 2017 00:58:43 +0000 (00:58 +0000)]
Update Brazilian Portuguese translation
Piotr Drąg [Wed, 26 Apr 2017 17:42:55 +0000 (19:42 +0200)]
Update Polish translation
Stas Solovey [Wed, 26 Apr 2017 14:44:34 +0000 (14:44 +0000)]
Update Russian translation
Daniel Boles [Wed, 26 Apr 2017 11:18:12 +0000 (12:18 +0100)]
Scale: Fix documentation of digits per last revert
Revert doc changes that were for the behavioural change just reverted.
Add a clarifying note that, under the original behaviour, :digits only
rounds the Adjustment if :draw-value is TRUE at the time of the change.
https://bugzilla.gnome.org/show_bug.cgi?id=781605
https://bugzilla.gnome.org/show_bug.cgi?id=358970
Matthias Clasen [Wed, 26 Apr 2017 10:18:09 +0000 (06:18 -0400)]
Revert "Scale: Always sync ::digits to Range::round-digits"
This reverts commit
4a6bd134bdc192b4830a1c6228e27332d4629418.
This change in behavior broke various things.
https://bugzilla.gnome.org/show_bug.cgi?id=781605
Timm Bäder [Fri, 7 Apr 2017 17:02:35 +0000 (19:02 +0200)]
listbox: Properly remove placeholders
https://bugzilla.gnome.org/show_bug.cgi?id=778617
Timm Bäder [Mon, 24 Apr 2017 14:22:32 +0000 (16:22 +0200)]
spinbutton: Add undershoot nodes to CSS docs
Timm Bäder [Mon, 24 Apr 2017 14:22:26 +0000 (16:22 +0200)]
spinbutton: Remove an unused define
Timm Bäder [Mon, 24 Apr 2017 13:12:23 +0000 (15:12 +0200)]
window: Expand CSS node docs
Timm Bäder [Mon, 24 Apr 2017 10:00:32 +0000 (12:00 +0200)]
paned: Fix typo
Daniel Boles [Tue, 25 Apr 2017 09:57:55 +0000 (10:57 +0100)]
ProgressBar: Update node summary per
b5eb37eba4162
The node named "progress" is a child of the node named "trough".
Matthias Clasen [Sun, 23 Apr 2017 14:39:44 +0000 (10:39 -0400)]
Add a cleaned-up example for listbox DND
I want to refer to this as an example, so make it look nice.
Matthias Clasen [Sun, 23 Apr 2017 01:37:55 +0000 (21:37 -0400)]
testlist3: Handle dropping a row onto itself
Instead of spewing criticals, we should handle this
gracefully by doing nothing.